Add Debian/Ubuntu preflight dependency check for build-shotcut.sh - #1870
Open
Proggerdogger wants to merge 1 commit into
Open
Add Debian/Ubuntu preflight dependency check for build-shotcut.sh#1870Proggerdogger wants to merge 1 commit into
Proggerdogger wants to merge 1 commit into
Conversation
Detect missing host build tools before a long compile and print one sorted sudo apt install command. Disable with ACTION_PREFLIGHT=0.
Member
|
This is not a change I want to include because |
Member
|
I can accept the new script and mention it in the readme. |
Contributor
Author
|
Sounds good. I can understand you not wanting to maintain a new script when it's not generally useful. Putting it in the readme means someone can make the install easier if they want to. It'll be interesting to see if anyone uses it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/build-shotcut.shcan fail late in a long build when a host tool is missing. This addsscripts/preflight-deps.shfor Debian/Ubuntu-family systems to report all missing packages in one sortedsudo apt installcommand, and runs it early frombuild-shotcut.shby default.1aborts the build with the install hint2(unsupported OS) warns and continuesACTION_PREFLIGHT=0inbuild-shotcut.confaptTest plan
scripts/preflight-deps.shexits 0 on a stock Debian/Ubuntu build host with deps presentPATH, exits 1 and prints one sortedsudo apt install -y …lineACTION_PREFLIGHT=0skips the check